Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors on Python 2.7 when a file could not be downloaded #2709

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

sdispater
Copy link
Member

This PR fixes on issue on Python 2.7 where partially downloaded files would not be deleted due to the fact that pathlib2 does not provide the missing_ok keyword argument for unlink.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added the kind/bug Something isn't working as expected label Jul 24, 2020
@sdispater sdispater added this to the 1.1 milestone Jul 24, 2020
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abn abn merged commit 6880fd6 into master Jul 24, 2020
@abn abn deleted the fix-incomplete-download-deletion branch July 24, 2020 09:31
@sdispater sdispater mentioned this pull request Jul 24, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants