Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle circular dependencies when getting extras #2787

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Handle circular dependencies when getting extras #2787

merged 1 commit into from
Aug 28, 2020

Conversation

abn
Copy link
Member

@abn abn commented Aug 9, 2020 •
edited
Loading

Resolves #2376 #2555

@abn abn added this to the 1.1 milestone Aug 9, 2020
@abn abn added the kind/bug Something isn't working as expected label Aug 9, 2020
@abn abn requested a review from a team August 9, 2020 22:46
@abn abn linked an issue Aug 9, 2020 that may be closed by this pull request
Installation of extras: maximum recursion depth exceeded #2555
Closed
3 tasks
bneijt
bneijt approved these changes Aug 11, 2020
View reviewed changes
Copy link

@bneijt bneijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough.

finswimmer
finswimmer approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@finswimmer finswimmer merged commit 8b8b97a into python-poetry:master Aug 28, 2020
@sdispater sdispater mentioned this pull request Sep 18, 2020
Merged
@abn abn deleted the fix-recursion-extras branch October 6, 2020 22:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bneijt bneijt bneijt approved these changes

@finswimmer finswimmer finswimmer approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working as expected
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Installation of extras: maximum recursion depth exceeded RecursionError when installing mkdocs-material
3 participants
@abn @bneijt @finswimmer