Check project against valid and deprecated trove classifiers.

[kdeldycke]

Inspects trove classifiers on check CLI command calls, and look for unrecognized and deprecated categories.

Adds dependency https://github.com/pypa/trove-classifiers, a package published and maintained by PyPA that is cataloguing all classifiers. This is the canonical source of all trove definitions.

Pull Request Check List

Resolves: #2579

• Added tests for changed code.
• Updated documentation for changed code.

[kdeldycke]

This PR is failing on Python 2.7 because it adds a dependency on calver, which requires python >= 3.5.

I guess this PR should be tied to Poetry 1.2 release then: #2683

[abn]

@kdeldycke unfortunately yes, if you really want it sooner you will need to disable the code for PY2 and make the dependency optional. That said, it is unlikely this will make 1.1.0 anyway.

[kdeldycke]

Thanks @abn for the feedback! I'll wait for the next release then! :)

[kdeldycke]

I think this PR is ready to be merged, now that I rebased it on top of master, i.e. the future 1.2 release.

Unfortunately some tests are failing for what looks like something that has nothing to do with the code changes in this PR... 😞

[kdeldycke]

All checks have passed, this PR is ready for review! :)

[kdeldycke]

I just rebased this PR on top of upstream and fixed all remaining issues. All tests are passing.

This PR is ready to be merged for Poetry 1.2.

[neersighted]

This feature looks good overall, but I have some code-level changes I'd like to see. Additionally, I would like to see this code factored out into a helper rather than inline in the check command, and some more thought given to variable naming to help keep it maintainable later.

[kdeldycke]

All concerns identified during the code review have been addressed. All tests passes. This PR is ready to be merged.

Do you want me to squash the commits into one?

This feature looks good overall, but I have some code-level changes I'd like to see. Additionally, I would like to see this code factored out into a helper rather than inline in the check command, and some more thought given to variable naming to help keep it maintainable later.

As for these structural code changes, I regrouped all the code into a naive helper in: 89eba1e

Is that what you were looking for? Do you have suggestions on the variables to rename?

[neersighted]

Hey @kdeldycke -- sorry about the wait on this one, I never commented here, but it was concluded that this wasn't something we wanted to include in 1.2. I've moved the milestone to 1.3, and hope to have this reviewed and merged in time for the next minor release.

[kdeldycke]

1.3 is a perfectly fine target! Thanks @neersighted for the merge and sorry for the late reply!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.