-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not raise error if package is already in pyproject.toml on poetry add #2886
Merged
abn
merged 3 commits into
python-poetry:master
from
finswimmer:allow-adding-known-package
Sep 23, 2020
Merged
Do not raise error if package is already in pyproject.toml on poetry add #2886
abn
merged 3 commits into
python-poetry:master
from
finswimmer:allow-adding-known-package
Sep 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finswimmer
force-pushed
the
allow-adding-known-package
branch
2 times, most recently
from
September 10, 2020 17:11
74adf7e
to
29efdde
Compare
abn
reviewed
Sep 10, 2020
I think from a purely UX standpoint, a good approach would be to display some guidance for user, for instance:
|
abn
reviewed
Sep 14, 2020
abn
requested changes
Sep 21, 2020
…and this dependency is already in pyproject.toml
finswimmer
force-pushed
the
allow-adding-known-package
branch
from
September 21, 2020 18:06
644b371
to
5aca16e
Compare
abn
approved these changes
Sep 23, 2020
Merged
2 tasks
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
poetry
raises aValueError
when trying to add a package that is already in thepyproject.toml
. This PR change the behaviour as follows:poetry add
and this dependency is already inpyproject.toml
.Pull Request Check List
Resolves: #98