Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies with release scripts #2941

Merged
merged 7 commits into from
Sep 21, 2020

Conversation

abn
Copy link
Member

@abn abn commented Sep 19, 2020

Multiple fixes:

  • This resolves failures FreeBSD release failures identified in Release 1.1.0b3 #2935. This was tested, and 1.1.0b3 release retrofitted in 1.1.0b3 freebsd #2936.
  • This also bootstraps poetry from the working source instead of the get-poetry script. This ensures that we do end up with a chicken and egg situation with broken releases.
  • Works around Python 2.7 on Windows threading issue.

@abn abn requested a review from sdispater September 19, 2020 14:18
This was referenced Sep 19, 2020
@abn abn added kind/bug Something isn't working as expected area/build-system Related to PEP 517 packaging (see poetry-core) labels Sep 19, 2020
@abn abn added this to the 1.1 milestone Sep 19, 2020
Python 2 running on Windows, causes thread leaks which
leads console io write errors when using pastel. This
works around the issue by limiting to a single worker
in these environments.
@abn abn requested review from a team and removed request for sdispater September 21, 2020 10:33
@sdispater sdispater merged commit e859c44 into python-poetry:master Sep 21, 2020
@abn abn deleted the fix/sonnet branch September 21, 2020 12:22
@abn abn mentioned this pull request Sep 22, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/build-system Related to PEP 517 packaging (see poetry-core) kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants