Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: make original toml content optional #3008

Merged
merged 3 commits into from
Oct 1, 2020

Conversation

abn
Copy link
Member

@abn abn commented Sep 30, 2020

This fixes a bug introduced via #2448.

@abn abn added the kind/bug Something isn't working as expected label Sep 30, 2020
@abn abn added this to the 1.1 milestone Sep 30, 2020
@abn abn requested a review from a team September 30, 2020 21:45
sdispater
sdispater previously approved these changes Sep 30, 2020
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes in configuration.md, poetry.lock and pyproject.toml intended to be in this PR?

Otherwise looks good 👍

@abn
Copy link
Member Author

abn commented Oct 1, 2020

Yes. They are separated by commits. :) The doc fix is linting related issue that crept into master, and the core bump is due to checks failing on python 2.7. See fixes to core 1.0.0rc2.

@abn abn mentioned this pull request Oct 1, 2020
@finswimmer finswimmer merged commit 51d4b5a into python-poetry:master Oct 1, 2020
@abn abn deleted the fix/new branch October 1, 2020 07:54
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants