Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish: ensure config url is preferred #3047

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

abn
Copy link
Member

@abn abn commented Oct 2, 2020

Seems that the url configured for publishing and source tends to be different at the moment. This ensures that we do not use the source url for publishing, since repo urls are only used for netloc identification when searching for auth, this should be safe.

Resolves: #3052 #3053

@abn abn added the kind/bug Something isn't working as expected label Oct 2, 2020
@abn abn added this to the 1.1 milestone Oct 2, 2020
@abn abn requested a review from a team October 2, 2020 10:12
@finswimmer finswimmer merged commit 417ce64 into python-poetry:1.1 Oct 5, 2020
@abn abn deleted the fix/publish-url branch October 5, 2020 08:48
@abn abn mentioned this pull request Oct 5, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants