Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config option to force --always-copy parameter for virtualenv #3157

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Oct 9, 2020

virtualenv uses symlink to the interpreter when creating a venv. While this reduces space and runtime this might lead to unexpected results, when the interpreter to which the symlink points get upgraded.

This PR introduce a config option virtualenvs.options.always-copy. If setting to true the --always-copy parameter is added to virtualenv command on creating the venv.

To keep the current behavior as default, this option is set to false by default.

Pull Request Check List

Resolves: #3134

  • Added tests for changed code.
  • Updated documentation for changed code.

@finswimmer finswimmer force-pushed the issue-3134-symlink-venv branch 2 times, most recently from 14e69f4 to a5ae42f Compare October 9, 2020 06:32
@finswimmer finswimmer marked this pull request as ready for review October 9, 2020 13:10
@finswimmer finswimmer requested a review from a team October 9, 2020 13:11
@abn
Copy link
Member

abn commented Oct 10, 2020

@finswimmer LGTM. Althought, I am wondering if we should names psace this into something like virtualenvs.options.always-copy or smilar. I feel we will have more options to be exposed. Alternatively we can also consider supporting virtualenvs.options.*, boolean beign flags that simply get transfored to --<flag>. This will also enable us to support options like system-site etc.

@finswimmer
Copy link
Member Author

Althought, I am wondering if we should names psace this into something like virtualenvs.options.always-copy or smilar. I feel we will have more options to be exposed.

Yes, this sounds like a good idea.

Alternatively we can also consider supporting virtualenvs.options.*, boolean beign flags that simply get transfored to --.

IMO that's a bit risky. I'm quite sure there will be people, who are able to create a config that will break poetry ;) So, we should carefully choose which flag we want to include.

fix issue for showing all configs when options has more then two level
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poetry links to python3 and not python3.x
2 participants