Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show --tree: stop ignoring --no-dev #3296

Merged
merged 2 commits into from
Oct 28, 2020
Merged

show --tree: stop ignoring --no-dev #3296

merged 2 commits into from
Oct 28, 2020

Conversation

1ace
Copy link
Contributor

@1ace 1ace commented Oct 27, 2020

Pull Request Check List

Resolves: #3295

  • Added tests for changed code.
  • Updated documentation for changed code. -> not applicable, since we're updating the code to match the documentation :)

I have tested this with the pyproject.toml from #3295 and it behaves as intended:

$ poetry show --tree --no-dev  # 1.1.4
pytest 6.1.1 pytest: simple powerful testing with Python
├── atomicwrites >=1.0
├── attrs >=17.4.0
├── colorama *
├── iniconfig *
├── packaging *
│   ├── pyparsing >=2.0.2
│   └── six *
├── pluggy >=0.12,<1.0
├── py >=1.8.2
└── toml *
xarray 0.16.1 N-D labeled arrays and datasets in Python
├── numpy >=1.15
└── pandas >=0.25
    ├── numpy >=1.15.4
    ├── python-dateutil >=2.7.3
    │   └── six >=1.5
    └── pytz >=2017.2
$ ~/.bin/poetry show --tree --no-dev  # git version from this PR
xarray 0.16.1 N-D labeled arrays and datasets in Python
├── numpy >=1.15
└── pandas >=0.25
    ├── numpy >=1.15.4
    ├── python-dateutil >=2.7.3
    │   └── six >=1.5
    └── pytz >=2017.2

I tried adding a formal test, but I wouldn't be surprised if I did something wrong as I'm only just discovering the poetry codebase 🙃

You can run the tests on the first commit and see that it fails, and that it passes after the second commit 👍

Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Fixes #3295

Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Copy link
Member

@kasteph kasteph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💯

@kasteph kasteph merged commit d1529a1 into python-poetry:master Oct 28, 2020
@1ace 1ace deleted the show-tree-no-dev branch October 28, 2020 12:01
dsch pushed a commit to dsch/poetry that referenced this pull request Apr 23, 2021
abn pushed a commit that referenced this pull request Apr 30, 2021
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show --tree --no-dev shows the dev dependencies
2 participants