Deprecate to_str #3298
Closed
Deprecate to_str #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abn
requested changes
Nov 2, 2020
| else: | ||
| method = "decode" | ||
|
|
||
| encodings = ["utf-8", "latin1", "ascii"] |
There was a problem hiding this comment.
Should we handle this via str(x, encoding=encoding)? We should add a test case for PyPI repositories that evalueatets this.
|
Closing for #3405 |
|
@stephsamson #3405 did not remove the method though right? I think we still need to remove encode/decode/to_str in a separate change. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates-to: #3318