Add PyPI registry correctly to pool depending on other sources/Fix source.secondary = true being ignored #3406
Conversation
tomzx
force-pushed
the
fixes/source-default-secondary-logic
branch
from
45c7b20
to
99b9d80
Compare
tomzx
changed the title
|
I can confirm it works, thanks! Looking forward for a release. |
|
@abn any chance to merge this? This is quite an issue for us. |
|
Same thing here, we found this error today in different computers. It would be great if this could be merged! |
|
Still an issue, when will this make it into master? |
|
@skylerwshaw I cannot merge this since I am not a maintainer. Merging is currently blocked due to
|
|
"A stitch in time saves nine" - should have merged already. People are suffering out there because of the secondary repositories. |
|
@maksbotan - are we able to get a second approval on this? |
In the event where we defined sources that were set as secondary = True, we would end up with PyPI being after this source when it should have acted as default in that case. The main issue stems from the fact that it's not because you have sources configured that PyPI should not be a default. Instead, PyPI should be default if there are no sources with secondary = False and not default if there are sources with secondary = True.
tomzx
dismissed stale reviews from ylathouris, Drachenfels, and aviramha
via
b2defd1
tomzx
force-pushed
the
fixes/source-default-secondary-logic
branch
from
99b9d80
to
b2defd1
Compare
|
Hello all! I have rebased the PR which appears to have rendered the 3 prior approval stale. @Drachenfels @ylathouris @aviramha Would you mind giving it another quick look (nothing has changed). @sdispater @abn Would you be able to provide any feedback necessary to get this moving forward? Thanks! |
|
bueller.... bueller.... bueller....... |
|
@sdispater @abn @cereblanco hi! glad to see the project come to life again. Can you please look at this PR, as it fixes a nasty regression that blocks some users from upgrading to 1.1.4? |
😭 |
That's resolved. |
|
@abn hi! this serious regression still did not get any attention from the developers... |
|
This didn't solve the problem for me. |
|
Just noticed that this PR was merged to the |
Add PyPI registry correctly to pool depending on other sources (#3406) In the event where we defined sources that were set as secondary = True, we would end up with PyPI being after this source when it should have acted as default in that case. The main issue stems from the fact that it's not because you have sources configured that PyPI should not be a default. Instead, PyPI should be default if there are no sources with secondary = False and not default if there are sources with secondary = True.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
In the event where we defined sources that were set as
secondary = True, we would end up with PyPI being after this source
when it should have acted as default in that case.
The main issue stems from the fact that it's not because you have
sources configured that PyPI should not be a default. Instead, PyPI
should be default if there are no sources with secondary = False and
not default if there are sources with secondary = True.
Resolves #2339, resolves #3306, resolves #3238