Updated puzzle debug regex to handle missing version info #3731
Conversation
poetry/puzzle/provider.py
Outdated
| @@ -710,7 +710,7 @@ def debug(self, message: str, depth: int = 0) -> None: | |||
|
|
|||
| if message.startswith("fact:"): | |||
| if "depends on" in message: | |||
| m = re.match(r"fact: (.+?) depends on (.+?) \((.+?)\)", message) | |||
| m = re.match(r"fact: (.+?) depends on ((.+?)($| \((.+?)\)))", message) | |||
There was a problem hiding this comment.
Since we reference m.group(2) and m.group(3), this require more changes.
| m = re.match(r"fact: (.+?) depends on ((.+?)($| \((.+?)\)))", message) | |
| m = re.match(r"fact: (.+?) depends on (?:(.+?)($| \((.+?)\)))", message) |
And we need to change the way we format the message in case m.group(3) is empty.
There was a problem hiding this comment.
With the regex as I made it m.group(2) == m.group(3), but only for the special case below, regularly group 2 and 3 will be identical to before.
So message == "fact: xxx (==1.7.0) depends on cryptography", group 2 and 3 would be cryptography.
I have changed to match your request, if group 3 is None I put a *. Not sure what you'd like to see here.
I think having group 2 and 3 be equal in this case might be the most logical solution for what the debug log prints.
|
See the linked issue for closing reasons. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #3729
Related: #3724, #3739