Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add support for python 3.10 experimental builds #3859

Merged
merged 5 commits into from
Mar 30, 2021

Conversation

cereblanco
Copy link
Contributor

@cereblanco cereblanco commented Mar 30, 2021

Pull Request Check List

Resolves: #3842

  • Updated CIs for tests and skip.yaml
  • I used pip to install poetry because Windows envs encounter error using python install-poetry.py -y

[ ] Added tests for changed code.
[ ] Updated documentation for changed code.

Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cereblanco , added some minor comments.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/skip.yml Outdated Show resolved Hide resolved
@abn
Copy link
Member

abn commented Mar 30, 2021

What was the error on using the install script? We should probably fix that.

@cereblanco
Copy link
Contributor Author

What was the error on using the install script? We should probably fix that.

@abn i reverted the unnecessary changes..
the error was caused by runs-on: ubuntu-latest instead of matrix.os 🤦🏼 😅 which i reverted as well

thank you

@abn abn merged commit 45a9b8f into python-poetry:master Mar 30, 2021
@abn
Copy link
Member

abn commented Mar 30, 2021

Thank you @cereblanco lgtm.

@cereblanco cereblanco deleted the add-python-3-10-to-ci branch May 1, 2021 15:04
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: add support for python 3.10 experimental builds
2 participants