Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify tool.poetry.scripts #4071

Closed
wants to merge 1 commit into from
Closed

Conversation

graingert
Copy link
Contributor

@graingert graingert commented May 16, 2021

use my_package in line with other sections
ovoid re-using the term poetry for package and CLI script name

Pull Request Check List

Resolves: #issue-number-here

  • Added tests for changed code.
  • Updated documentation for changed code.

use my_package in line with other sections
ovoid re-using the term poetry for package and CLI script name
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally use poetry as the example in the docs, but I do think that this makes it clear the package name has no special relation to the script name.

Can you please rebase this to fix your merge conflicts, and switch to double quotes in the pyproject.toml?

@Secrus Secrus added area/docs Documentation issues/improvements status/waiting-on-response Waiting on response from author labels May 17, 2022
@Secrus
Copy link
Member

Secrus commented Jun 20, 2022

Superseded by #5884

@Secrus Secrus closed this Jun 20, 2022
@graingert graingert deleted the patch-1 branch June 20, 2022 21:35
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements status/waiting-on-response Waiting on response from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants