Backport security fix #3885 for package hashes to 1.1 #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw a specific exception in the case of finding a matching name+version, but none of the digests for a link matching the `poetry.lock` metadata. Fixes Issue #2422 Co-authored-by: Nicolas Simonds <nisimond@cisco.com>
This was referenced Aug 21, 2021
2 tasks
sdispater
approved these changes
Aug 27, 2021
|
Thank you so much for this @pietrodn ! |
Merged
|
FYI this backport broke our build since there is still a bug somehow with external pypi repos and I downgraded our poetry to error is documented here: |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the security fix of #3885 on Poetry 1.1.
This commit has already been merged in
masterbut it didn't make it to the 1.1 minor.This fix is one of the two changes to make Poetry check the hashes of the downloaded files after
poetry.lock.Unfortunately this PR isn't sufficient to correct the bug, as this other PR needs to be backported to
poetry-core1.0.Still, it is necessary.