Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge any marker constraints into constraints with specific markers #4590

Conversation

radoering
Copy link
Member

Pull Request Check List

Resolves: #4516

  • Added tests for changed code.
  • Updated documentation for changed code.

If there are several requirements for the same library, requirements with markers can be considered as additions to requirements without markers.

For example see this extract from the install_requires of black 21.9b0:

"typing_extensions>=3.10.0.0",
# 3.10.0.1 is broken on at least Python 3.10,
# https://github.com/python/typing/issues/865
"typing_extensions!=3.10.0.1; python_version >= '3.10'",

These statements define that typing_extensions has to be at least 3.10.0.0 for all python versions (including python 3.10 and above). Additionally, typing_extensions for python 3.10 and above must not be 3.10.0.1.

Thus, the constraints of requirements without markers have to be merged into the constraints of requirements with markers.

@radoering radoering force-pushed the merge-any-marker-constraints-into-specific-marker-constraints branch 2 times, most recently from 7fec712 to 7bacea5 Compare November 17, 2021 07:09
@neersighted neersighted self-assigned this Nov 17, 2021
@radoering radoering force-pushed the merge-any-marker-constraints-into-specific-marker-constraints branch from 7bacea5 to 53dfb8a Compare November 21, 2021 05:47
@neersighted neersighted merged commit 07565b2 into python-poetry:master Nov 21, 2021
@finswimmer finswimmer mentioned this pull request Mar 6, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version solving mistake with black, tensorflow and typing_extensions.
2 participants