Use master of poetry-core in master of poetry #5075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that is generally a sound plan. Largely because both are intended to be independent projects even if their development is parallel at present. Also would lead to breakages due to changes introduced in core, and that is unpleasant all around. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Due to the fact that a new poetry release comes together with a new poetry-core release and to avoid issues like #4958 (fixing a bug that has already been fixed upstream) and ease fixes for issues like #4919 (poetry-core downstream tests failing which require a fix in poetry), poetry master should depend on poetry-core master.
When creating a new release branch the dependency of poetry-core should be changed to a version dependency.