-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update pyproject readme docs #5158
update pyproject readme docs #5158
Conversation
Deploy preview for website ready! ✅ Preview Built with commit 54da53e. |
docs/pyproject.md
Outdated
```toml | ||
[tool.poetry] | ||
# ... | ||
readme = "./README.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need ./
prefix. It is unnecessary, as it points to the same directory and can be confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay np I fixed that, looks better now. thanks for the review!
I will have to double check, but I think this might be outdated as we've landed support for multiple README files that get combined. |
Yeah, we've added support for A quick touchup to reflect that would be appreciated! |
@patrick-ryan are you still up for completing this? |
yep I'll take a look at this, thanks for the ping |
okay updated to include the option of specifying a list of readme paths, let me know if that looks okay |
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
…k-ryan/poetry into 5069-pyproject-readme-docs-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I see you've committed most of my suggestions -- the line wrapping will be broken -- could you please reflow these paragraphs to be 80 columns wide?
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #5069
I rendered the file in vscode, but let me know if there's a way to generate + host the docs locally so I can preview, thanks!