rename safe_rmtree and ensure remove_directory is used instead of shutil.rmtree #5510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
abn
changed the title
2 tasks
finswimmer
requested changes
Apr 29, 2022
This change renames `safe_rmtree` into a more appropriate name with relevant arguments. We ensure that the force behaviour is opt-in and not the default to avoid ambiguity.
finswimmer
approved these changes
Apr 30, 2022
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames
safe_rmtreeinto a more appropriate name with relevant arguments. We ensure that the force behaviour is opt-in and not the default to avoid ambiguity.This combines the work done in c12d86b7 and #520.