-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve http request handling for sources and support multiple paths on same netloc #5518
Conversation
Azure DevOps Aftifacts Feed + keyring still works 😄 I'm just going to mention #5463 and tag @agni-sairent so that both of you know about each other's PR. |
@Darsstar 🍰 Thank you for testing that much appreciated and for the #5463. @agni-sairent would you mind if I pulled in your changes into this PR so its all tidy? I am guessing the use case things like gitlab etc where there are project specific credentials? |
@abn go for it! I don't mind at all 😄 |
@Darsstar @agni-sairent I have landed that change at abn#1 for now - might need a couple of iterations. Feedback/testing appreciated. I just reused tests from #5463 - well, whatever was net new. This PR can go ahead without those changes as this does not change existing functionality. |
I am looking forward to seeing either one of these PRs merged, so I went forward and tried your version but discovered some odd behaviour.
EDIT: First issue happens on master as well, second already described in #5476 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Lots of nice refactoring!
4f233a4
to
2e0664b
Compare
This change refactors HTTP repository source implementations. The following changes have been made. - CacheControl cache now lives within Authenticator. - Authenticator manages unique sessions for individual netloc. - CacheControl usage now respects disable cache parameter in repos. - Certificate and authentication logic is now managed solely within Authenticator for source repositories taking advantage of recent enhancements. These changes should allow for better handling of cases like those described in python-poetry#3041. Additionally, this forms the foundation for unifying HTTP specific logic within the code base and possibly allowing for migration of requests etc. if/when required.
Co-authored-by: Agni Sairent <agniczech@gmail.com> Co-authored-by: Dos Moonen <darsstar@gmail.com>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This change refactors HTTP repository source implementations. The following changes have been made.
Authenticator for source repositories taking advantage of recent
enhancements.
These changes should allow for better handling of cases like those described in #3041. Additionally, this forms the foundation for unifying HTTP specific logic within the code base and possibly allowing for migration of requests etc. if/when required.
Additionally, also cleans up some type hinting issues pertaining to http repo only attributes.
Co-Authors: @Darsstar @agni-sairent
Closes: #5108
Closes: #5463
Resolves: #5651