-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use configured repositories as sources by default #562
Conversation
9b98abe
to
735b696
Compare
@sdispater would be good get your thoughts on this one. Happy to make any changes as required. |
735b696
to
2cd8cc7
Compare
2cd8cc7
to
7c00dd9
Compare
This change adds globally configured extra repositories from config.toml as dependency sources. These are added after project specific sources and before PyPI. Resolves: python-poetry#625
7c00dd9
to
ca0a297
Compare
This PR is superseded by #908 which introduces a way to specify a source as the default |
@sdispater the feature being worked on in #908 is going to be definitely helpful. However, if I am understanding the change there, it is different to what was intended here. In #908, only repositories configured in the project's Is this behaviour intended to be added as part of #908? |
What is your use case? I think it is convenient for changing dependency without changing But it also tends to bypass |
@drunkwcodes for what it is worth, example scenarios are mentioned in the description. Expanding on that, having a global configuration has merits in the context of production use cases and build pipelines. Final application builds might use specific repositories that might only be accessible from build environments. In addition, this has the potential to assist developer workflows, for example in scenarios where a devpi servers are used. The implementation proposed falls back to global repositories, ie. packages are searched first in repositories configured by the project configuration and if they are not found, we fallback to global repositories. |
@drunkwcodes but |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This change adds globally configured extra repositories from config.toml as dependency sources. These are added after project specific sources and before PyPI.
The motivation behind this change was to enable a cleaner configuration of private repositories/mirrors under automated pipeline build environments without hard coding repository configurations within the project sources. Additionally, this provides functionality similar to pip's extra_index config allowing global configuration of repositories.
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the
develop
branch. If it's a bug fix or only a documentation update, it should be based on themaster
branch.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Resolves: #625