Use dulwich to fetch global and local git config

[fredrikaverpil]

Pull Request Check List

Resolves: #5934

• Added tests for changed code.
• Fixed broken tests for changed code. 👈 😁
• Updated documentation for changed code.

Why?

• See Poetry is not using Dulwich to read the global git config (particularly the insteadOf option) #5934 for details, but Dulwich was not being used so to read the global git config.
• Backwards compatibility from 1.1.13 was broken because of the above.
• Dulwich was recently updated so to support insteadOf/pushInsteadOf (which also used to work with 1.1.13).

What?

• Pass the config object into get_transport_and_path .
• Fix pytest errors following the code change.
• Bump Dulwich to 0.20.44, so to support URL rewriting using insteadOf/pushInsteadOf.
• Fix mypy error following the Dulwich bump.

[jelmer]

LGTM from a Dulwich perspective.

[fredrikaverpil]

@abn you wrote the tests I had to update here, 2 mo ago, so I was wondering if you could take a look at this 😄

Also, I was wondering, shall we also change repo.get_config() here into repo.get_config_stack() as part of this change so it also reads the global git config?

[jelmer]

LGTM

[guanzo]

my gitconfig seems to be crashing poetry install :/

$ cat ~/.gitconfig
[alias]
  c = '!f() { \
    printf '[git commit -m \"%s\"]\n' \"$*\" && \
    git commit -m \"$*\"; \
  }; f'

$ poetry install
Installing dependencies from lock file

Package operations: 3 installs, 0 updates, 0 removals

  • Installing algofi-py-sdk (1.1.1 904a14d)
  • Installing algofi-python-sdk (2.1.2 fe57cc5)
  • Installing tinyman-py-sdk (0.0.6 40ca553)

  IndexError

  bytearray index out of range

  at ~\AppData\Local\Programs\Python\Python310\lib\site-packages\dulwich\config.py:413 in _parse_string
      409│         c = value[i]
      410│         if c == ord(b"\\"):
      411│             i += 1
      412│             try:
    → 413│                 v = _ESCAPE_TABLE[value[i]]
      414│             except IndexError:
      415│                 raise ValueError(
      416│                     "escape character in %r at %d before end of string" % (value, i)
      417│                 )

The following error occurred when trying to handle this error:


  ValueError

  escape character in bytearray(b"\'!f() { \\") at 9 before end of string

  at ~\AppData\Local\Programs\Python\Python310\lib\site-packages\dulwich\config.py:415 in _parse_string
      411│             i += 1
      412│             try:
      413│                 v = _ESCAPE_TABLE[value[i]]
      414│             except IndexError:
    → 415│                 raise ValueError(
      416│                     "escape character in %r at %d before end of string" % (value, i)
      417│                 )
      418│             except KeyError:
      419│                 raise ValueError(

This gitconfig line seems to be the issue c = '!f() { \.

I'm using poetry on Windows and git bash.

[neersighted]

Please open an issue against Dulwich -- a merged PR is not a good place to report a bug, and the issue lies outside of Poetry's control.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.