Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve upload error output #6043

Conversation

theunkn0wn1
Copy link
Contributor

This PR improves the error output of poetry publish in the event of an upload error.
The current behavior is insufficient for debugging upload issues, especially for PyPi-like servers that don't use PyPi's code.

This PR passes through the http content to the cli, to allow users to better debug failures without adding repository-specific special case code to poetry.

Using this, I was able to get enough information from poetry to figure out an upload error I had at work earlier today.
- Improve information returned from upload errors

  • Fix the tests to for new behavior, add one for this specific case

Pull Request Check List

Resolves: #1100

  • Added tests for changed code.
  • Updated documentation for changed code.

What's the relevant documentation for this?

@neersighted neersighted merged commit 95915f0 into python-poetry:master Jul 24, 2022
@theunkn0wn1 theunkn0wn1 deleted the user/theunkn0wn1/improve_upload_error_output branch July 24, 2022 18:18
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry publish should display any available error messages if it fails
2 participants