Resolve cwd using os.path.realpath() when generating environment names

[adamgreg]

Pull Request Check List

Resolves: #6109

• Added tests for changed code.
• Updated documentation for changed code.

[adamgreg]

I wasn't sure how to add a suitable new unit test, sorry.

[radoering]

I wasn't sure how to add a suitable new unit test, sorry.

You probably have to mock realpath().

[adamgreg]

I wasn't sure how to add a suitable new unit test, sorry.

You probably have to mock realpath().

realpath() returns its argument unchanged if the path does not exist, so I don't think it's necessary to mock it unless we want to count the calls.

I meant to say I can't think of a way to unit test that this actually fixes the bug, short of mapping a drive on the test system.

[radoering]

Let's say you have path1 and path2. You can mock realpath to return path1 for both (i.e. path2 is a symlink pointing to path1). Then, generate_env_name() should return the same value no matter if it's called with path1 or path2. A test case similar to

poetry/tests/utils/test_env.py

Lines 1356 to 1362 in 62701fe

	def test_generate_env_name_ignores_case_for_case_insensitive_fs(tmp_dir: str):
	venv_name1 = EnvManager.generate_env_name("simple-project", "MyDiR")
	venv_name2 = EnvManager.generate_env_name("simple-project", "mYdIr")
	if sys.platform == "win32":
	assert venv_name1 == venv_name2
	else:
	assert venv_name1 != venv_name2

should be sufficient (just with mocking and without platform distinction).

Alternatively, instead of mocking you could create a symlink similar to

poetry/tests/packages/test_locker.py

Line 760 in 62701fe

def test_lock_file_resolves_file_url_symlinks(root: ProjectPackage):

although that's probably a bit more overhead.

[radoering]

pre-commit.ci autofix

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.