repository: keep (uncanonicalized) pretty_name

[radoering]

Lockfiles created with 1.2rc1 are not compatible with 1.1 if there is a dependency with a dot in its name (e.g. discord.py), because 1.1 applies a half-hearted normalization not converting dot to dash (writing discord.py in the lockfile) and 1.2rc1 does a complete normalization so that discord.py is normalized to discord-py, which is written to the lockfile.

However, when looking at

poetry/src/poetry/packages/locker.py

Line 388 in 4392bd6

"name": package.pretty_name,

we can see that the intention has always been to write pretty name (instead of the canonicalized name) into the lockfile. Considering that, half-hearted normalization vs. complete normalization is not the actual issue.

The actual issue is that pretty name got lost unintionally in the process of looking up dependencies in repositories. This PR ensures that pretty name is not lost anymore.

• Added tests for changed code.
• Updated documentation for changed code.

[dimbleby]

interesting

canonicalization still creeps in for extras somewhere, I haven't tried to figure out where. Eg if you add pyjwt to a project you get these extras:

dev = ["coverage[toml] (==5.0.4)", "cryptography (>=3.3.1)", "mypy", "pre-commit", "pytest (>=6.0.0,<7.0.0)", "sphinx", "sphinx-rtd-theme", "zope-interface"]
docs = ["sphinx", "sphinx-rtd-theme", "zope-interface"]

although pyjwt declared a dependency on zope.interface (and that's what poetry 1.1 wrote in the lockfile)

[neersighted]

I'm not the biggest fan of the inline canonicalization -- I'd rather see a variable to hold the canon form. That being said, LGTM even if you disagree.

[neersighted]

LGTM

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.