not every GroupCommand needs to be an EnvCommand #6282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relating to #6275 and python-poetry/poetry-plugin-export#78
Not every
GroupCommand
needs to be anEnvCommand
(though it's true that everyGroupCommand
in this repository is also anEnvCommand
, so this refactoring changes nothing here).The intention is to make a change to the export plugin so that the
ExportCommand
can be aGroupCommand
but not anEnvCommand
: it does need access to the group options, but it does not need a virtual environment.