Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No unwanted update of packages from legacy source #6336

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Sep 1, 2022

If a dependency doesn't specify a source type, then a locked package
from any source can satisfy it

Pull Request Check List

Resolves: #6335

I'm pretty sure this is reinstating the earlier behaviour - see #6335 (comment) for analysis

If a dependency doesn't specify a source type, then a locked package
from any source can satisfy it
@dimbleby
Copy link
Contributor Author

dimbleby commented Sep 1, 2022

(test failure looks like noise)

@radoering radoering added area/solver Related to the dependency resolver impact/backport Requires backport to stable branch impact/changelog Requires a changelog entry labels Sep 2, 2022
@radoering radoering merged commit f667d48 into python-poetry:master Sep 2, 2022
@dimbleby dimbleby deleted the unexpected_updates_with_legacy_repository branch September 2, 2022 07:45
radoering pushed a commit to radoering/poetry that referenced this pull request Sep 2, 2022
If a dependency doesn't specify a source type, then a locked package
from any source can satisfy it
neersighted pushed a commit that referenced this pull request Sep 2, 2022
If a dependency doesn't specify a source type, then a locked package
from any source can satisfy it
@neersighted neersighted added this to the 1.3 milestone Sep 17, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/solver Related to the dependency resolver impact/backport Requires backport to stable branch impact/changelog Requires a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry lock --no-update updates dependencies if custom source specified
3 participants