-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing deprecation warning for --dev
#6475
Merged
neersighted
merged 2 commits into
python-poetry:master
from
mkniewallner:add-missing-deprecation-warnings
Sep 12, 2022
Merged
Add missing deprecation warning for --dev
#6475
neersighted
merged 2 commits into
python-poetry:master
from
mkniewallner:add-missing-deprecation-warnings
Sep 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
added
area/cli
Related to the command line
impact/backport
Requires backport to stable branch
impact/docs
Contains or requires documentation changes
backport/1.2
labels
Sep 11, 2022
Deploy preview for website ready! ✅ Preview Built with commit 5213251. |
neersighted
approved these changes
Sep 12, 2022
poetry-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
`--dev` is marked as deprecated for both [add](https://python-poetry.org/docs/cli/#options-4) and [remove](https://python-poetry.org/docs/cli/#options-5) commands in the documentation and emit a warning when used, but this is not reflected in the CLI help messages. I also took the occasion to update the documentation to suggest replacements. Once backported, this would also require an update of the 1.2.0 blog post announcement, which doesn't mention those deprecations. (cherry picked from commit 844a720)
neersighted
pushed a commit
that referenced
this pull request
Sep 12, 2022
karrtikr
pushed a commit
to microsoft/vscode-python
that referenced
this pull request
Oct 11, 2022
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/cli
Related to the command line
impact/backport
Requires backport to stable branch
impact/docs
Contains or requires documentation changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
--dev
is marked as deprecated for both add and remove commands in the documentation and emit a warning when used, but this is not reflected in the CLI help messages.I also took the occasion to update the documentation to suggest replacements. Once backported, this would also require an update of the 1.2.0 blog post announcement, which doesn't mention those deprecations.