Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing deprecation warning for --dev #6475

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Add missing deprecation warning for --dev #6475

merged 2 commits into from
Sep 12, 2022

Conversation

mkniewallner
Copy link
Member

Pull Request Check List

--dev is marked as deprecated for both add and remove commands in the documentation and emit a warning when used, but this is not reflected in the CLI help messages.

I also took the occasion to update the documentation to suggest replacements. Once backported, this would also require an update of the 1.2.0 blog post announcement, which doesn't mention those deprecations.

  • Added tests for changed code.
  • Updated documentation for changed code.

@mkniewallner mkniewallner added area/cli Related to the command line impact/backport Requires backport to stable branch impact/docs Contains or requires documentation changes backport/1.2 labels Sep 11, 2022
@github-actions
Copy link

github-actions bot commented Sep 11, 2022

Deploy preview for website ready!

✅ Preview
https://website-5mb43jtbt-python-poetry.vercel.app

Built with commit 5213251.
This pull request is being automatically deployed with vercel-action

@mkniewallner mkniewallner marked this pull request as ready for review September 11, 2022 16:06
@mkniewallner mkniewallner requested a review from a team September 11, 2022 16:50
@neersighted neersighted merged commit 844a720 into python-poetry:master Sep 12, 2022
poetry-bot bot pushed a commit that referenced this pull request Sep 12, 2022
`--dev` is marked as deprecated for both
[add](https://python-poetry.org/docs/cli/#options-4) and
[remove](https://python-poetry.org/docs/cli/#options-5) commands in the
documentation and emit a warning when used, but this is not reflected in
the CLI help messages.

I also took the occasion to update the documentation to suggest
replacements. Once backported, this would also require an update of the
1.2.0 blog post announcement, which doesn't mention those deprecations.

(cherry picked from commit 844a720)
neersighted pushed a commit that referenced this pull request Sep 12, 2022
Backport 844a720 from #6475.

Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
@mkniewallner mkniewallner deleted the add-missing-deprecation-warnings branch September 12, 2022 19:18
@neersighted neersighted added this to the 1.3 milestone Sep 17, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to the command line impact/backport Requires backport to stable branch impact/docs Contains or requires documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants