Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for inconsistent docs for multiple constraint dependencies (GH6603) #6604

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Fix for inconsistent docs for multiple constraint dependencies (GH6603) #6604

merged 2 commits into from
Sep 23, 2022

Conversation

venaturum
Copy link
Contributor

@venaturum venaturum commented Sep 23, 2022 •
edited
Loading

Fixed #6603

Doc change only

neersighted
neersighted requested changes Sep 23, 2022
View reviewed changes
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please change the constraints to be >=3.6,<3.8 and >=3.8?

docs/dependency-specification.md Outdated Show resolved Hide resolved
docs/dependency-specification.md Outdated Show resolved Hide resolved
@venaturum
Copy link
Contributor Author

@neersighted Hi Bjorn, requested changes made 👍

@neersighted neersighted added area/docs Documentation issues/improvements impact/backport Requires backport to stable branch impact/docs Contains or requires documentation changes backport/1.2 labels Sep 23, 2022
@neersighted neersighted merged commit c275878 into python-poetry:master Sep 23, 2022
@poetry-bot poetry-bot bot mentioned this pull request Sep 23, 2022
Merged
poetry-bot bot pushed a commit that referenced this pull request Sep 23, 2022
@venaturum @github-actions
fix: inconsistent docs for multiple constraint dependencies (#6604)
958c5f7 
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
(cherry picked from commit c275878)
@github-actions
Copy link

github-actions bot commented Sep 23, 2022 •
edited
Loading

Deploy preview for website ready!

✅ Preview
https://website-671fg8h32-python-poetry.vercel.app

Built with commit eee933e.
This pull request is being automatically deployed with vercel-action

neersighted pushed a commit that referenced this pull request Sep 23, 2022
@venaturum @neersighted
fix: inconsistent docs for multiple constraint dependencies (#6604)
2f71a53 
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
(cherry picked from commit c275878)
@venaturum venaturum deleted the GH6603_multiple_constraint_doc branch September 23, 2022 06:06
@neersighted neersighted added this to the 1.3 milestone Sep 24, 2022
@radoering radoering mentioned this pull request Oct 7, 2022
Merged
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neersighted neersighted neersighted approved these changes

Assignees
No one assigned
Labels
area/docs Documentation issues/improvements impact/backport Requires backport to stable branch impact/docs Contains or requires documentation changes
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

DOC: dependency example not consistent with text (multiple constraint dependencies)
2 participants
@venaturum @neersighted