Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a fix for pyenv with poetry shell in documentation #678

Closed

Conversation

eblume
Copy link
Contributor

@eblume eblume commented Nov 27, 2018

Please see #497, #571, #172, and possibly #198 for related issues.

In the case described by @itsthejoker here: #497 (comment)

a proposed solution is to have fish execute a script to fix $PATH after pyenv has initialized. I believe a better solution is to guard pyenv for $POETRY_ACTIVE. This PR includes documentation for this fix, as I suspect many people are hitting this roadblock.

I am not able to vouch that this fix works (or is needed) on any shells other than fish, but I would assume before merging you might want to include documentation for those shells.

Hopefully this is helpful!

@itsthejoker
Copy link

Oh. Thaaaat's a lot easier than my solution 😂

An important side note is that in Fish, this solution will only work if you're manually declaring the inits for pyenv inside your config instead of using the omf pyenv plugin (which helpfully mangles the path for us: https://github.com/oh-my-fish/plugin-pyenv/blob/master/init.fish). Might need an additional line in your update.

@eblume
Copy link
Contributor Author

eblume commented Dec 3, 2018

Please see #497 (comment) for a real fix.

@eblume eblume closed this Dec 3, 2018
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants