Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add cli option to specify working path #6810

Merged
merged 4 commits into from
Nov 15, 2022
Merged

feat(cli): add cli option to specify working path #6810

merged 4 commits into from
Nov 15, 2022

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Oct 15, 2022 •
edited by neersighted
Loading

Pull Request Check List

Resolves: #2179, #7039

  • Added tests for changed code.
  • Updated documentation for changed code.

@finswimmer finswimmer force-pushed the feature/project-option branch 2 times, most recently from 7260721 to 0e20911 Compare October 16, 2022 06:45
@finswimmer finswimmer marked this pull request as ready for review October 16, 2022 06:46
@finswimmer finswimmer requested a review from a team October 16, 2022 06:46
@finswimmer
Copy link
Member Author

Could need some help to write proper tests 🙏

togetherwithasteria
togetherwithasteria reviewed Oct 17, 2022
View reviewed changes
Copy link
Member

@togetherwithasteria togetherwithasteria left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's pretty small sized!

Yupp, we might want some test here, but I'll assume that to be simple!

@togetherwithasteria togetherwithasteria added area/cli Related to the command line area/config Related to configuration management area/ux Features and improvements related to the user experience and removed area/cli Related to the command line labels Oct 17, 2022
neersighted
neersighted requested changes Oct 30, 2022
View reviewed changes
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some phrasing changes, and I'd like to consider a short flag ala -C.

docs/cli.md Outdated Show resolved Hide resolved
src/poetry/console/application.py Outdated Show resolved Hide resolved
src/poetry/console/commands/init.py Outdated Show resolved Hide resolved
src/poetry/console/commands/new.py Outdated Show resolved Hide resolved
@neersighted neersighted changed the title feat(cli): added cli option to specify path to project to run on feat(cli): add cli option to specify working path Oct 30, 2022
@clintonroy
Copy link
Contributor

-C, --directory are the common options for this in unix tools (make, tar) if you're willing to tweak the doc a tiny bit to match that.

@finswimmer
Copy link
Member Author

-C, --directory are the common options for this in unix tools (make, tar) if you're willing to tweak the doc a tiny bit to match that.

Fair enough. But https://xkcd.com/1168/ 🤣

neersighted
neersighted requested changes Nov 3, 2022
View reviewed changes
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see this as --directory, -C only, as not only does it match other tools, but --project feels more vague in intent/subject to misinterpretation.

The implementation LGTM.

@finswimmer finswimmer mentioned this pull request Nov 4, 2022
Closed
@vikram-dagger vikram-dagger mentioned this pull request Nov 8, 2022
Merged
@neersighted neersighted mentioned this pull request Nov 15, 2022
Closed
2 tasks
@neersighted neersighted linked an issue Nov 15, 2022 that may be closed by this pull request
add possibility to set the pyproject TOML from a custom path when running a command #7039
Closed
2 tasks
@neersighted neersighted mentioned this pull request Nov 15, 2022
Closed
2 tasks
@neersighted neersighted added the kind/feature Feature requests/implementations label Nov 15, 2022
@neersighted neersighted added the impact/changelog Requires a changelog entry label Nov 15, 2022
@neersighted neersighted added this to the 1.3 milestone Nov 15, 2022
@neersighted neersighted enabled auto-merge (rebase) November 15, 2022 19:07
@neersighted neersighted merged commit 4962622 into python-poetry:master Nov 15, 2022
@radoering radoering mentioned this pull request Dec 3, 2022
Merged
@brandonchinn178 brandonchinn178 mentioned this pull request May 9, 2023
Open
2 tasks
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@togetherwithasteria togetherwithasteria togetherwithasteria left review comments

@neersighted neersighted neersighted approved these changes

Assignees
No one assigned
Labels
area/config Related to configuration management area/ux Features and improvements related to the user experience impact/changelog Requires a changelog entry kind/feature Feature requests/implementations
Projects
None yet
Milestone
1.3
4 participants
@finswimmer @clintonroy @neersighted @togetherwithasteria