Correctly parse Git submodule URLs #7017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanrittenhouse
force-pushed
the
munge_submodule_urls
branch
from
dc15d3c
to
29f066f
Compare
|
@neersighted FYI |
evanrittenhouse
force-pushed
the
munge_submodule_urls
branch
from
29f066f
to
2059279
Compare
abn
reviewed
Nov 14, 2022
evanrittenhouse
force-pushed
the
munge_submodule_urls
branch
from
972770f
to
2059279
Compare
evanrittenhouse
force-pushed
the
munge_submodule_urls
branch
from
179d2f1
to
e715e56
Compare
|
any updates on this? I am running into this issue |
IIRC this is stalled on python-poetry/test-fixture-vcs-repository#6 |
evanrittenhouse
force-pushed
the
munge_submodule_urls
branch
2 times, most recently
from
1f04ab5
to
ffe3a92
Compare
evanrittenhouse
requested review from
abn and
neersighted
and removed request for
abn and
neersighted
neersighted
reviewed
Feb 15, 2023
dimbleby
reviewed
Feb 15, 2023
evanrittenhouse
requested review from
neersighted
and removed request for
abn
dimbleby
reviewed
Feb 17, 2023
|
@neersighted bump |
evanrittenhouse
force-pushed
the
munge_submodule_urls
branch
from
5003523
to
5c9ae80
Compare
|
Add me to the list of folks who are waiting on this; I've got a dependency I can install with pip but not poetry, which has kind of stalled me. |
radoering
force-pushed
the
munge_submodule_urls
branch
from
5c9ae80
to
543dcac
Compare
radoering
added
impact/backport
radoering
approved these changes
Mar 19, 2023
poetry-bot bot
pushed a commit
that referenced
this pull request
Mar 19, 2023
(cherry picked from commit 71b3d6e)
radoering
pushed a commit
that referenced
this pull request
Mar 20, 2023
(cherry picked from commit 71b3d6e)
adriangb
pushed a commit
to adriangb/poetry
that referenced
this pull request
Apr 5, 2023
Closed
3 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #6499
This PR adds support for correctly parsing relative submodule URLs.