Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix poetry shell for zsh if space character in venv path #7245

Merged
merged 7 commits into from
Jan 20, 2024
Merged

fix poetry shell for zsh if space character in venv path #7245

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
19133be
Update shell.py
dimstunt Dec 23, 2022
35aa9b6
Fix shell.py (python-poetry#7245)
dimstunt Jan 31, 2023
652a7b7
Merge branch 'master' into fix/7244
dimstunt Jan 31, 2023
214a4d9
Merge branch 'master' into fix/7244
Secrus Apr 18, 2023
9b5bdd5
Merge branch 'master' into fix/7244
radoering Jan 20, 2024
607d7ed
Fix merge mistake
radoering Jan 20, 2024
315a103
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/poetry/utils/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ def activate(self, env: VirtualEnv) -> int | None:

if self._name == "zsh":
# Under ZSH the source command should be invoked in zsh's bash emulator
c.sendline(f"emulate bash -c '. {shlex.quote(str(activate_path))}'")
quoted_activate_path = shlex.quote(str(activate_path))
c.sendline(f"emulate bash -c {shlex.quote(f'. {quoted_activate_path}')}")
elif self._name == "xonsh":
c.sendline(f"vox activate {shlex.quote(str(env.path))}")
elif self._name in ["nu", "fish"]:
Expand Down