Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clarifications for virtualenvs.path settings #7286

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Add clarifications for virtualenvs.path settings #7286

merged 2 commits into from
Jan 3, 2023

Conversation

spirit-q2
Copy link
Contributor

No description provided.

PabloEmidio
PabloEmidio previously approved these changes Jan 3, 2023
View reviewed changes
neersighted
neersighted requested changes Jan 3, 2023
View reviewed changes
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first note is misleading, and should probably be combined with the second to be something more like:

This setting controls the global virtual environment storage path. It most likely will not be useful at the local level. To store virtual environments in the project root, see virutualenvs.path.

"unpredictable behavior" is true as there is currently a bug with a relative path, but it makes more sense to fix that bug than it does to add nonspecific documentation warnings unlikely to be removed when the bug is fixed.

@spirit-q2 spirit-q2 requested review from neersighted and PabloEmidio and removed request for neersighted January 3, 2023 19:56
@spirit-q2
Copy link
Contributor Author

updated

@neersighted neersighted added area/docs Documentation issues/improvements impact/backport Requires backport to stable branch impact/docs Contains or requires documentation changes backport/1.3 labels Jan 3, 2023
@neersighted neersighted merged commit 68e1433 into python-poetry:master Jan 3, 2023
@poetry-bot poetry-bot bot mentioned this pull request Jan 3, 2023
Merged
@github-actions
Copy link

github-actions bot commented Jan 3, 2023 •
edited
Loading

Deploy preview for website ready!

✅ Preview
https://website-5po8u81fe-python-poetry.vercel.app

Built with commit 4f71eb5.
This pull request is being automatically deployed with vercel-action

@spirit-q2 spirit-q2 deleted the patch-1 branch January 4, 2023 19:45
@radoering radoering mentioned this pull request Jan 7, 2023
Merged
@neersighted neersighted added this to the 1.4 milestone Jan 15, 2023
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neersighted neersighted neersighted approved these changes

@PabloEmidio PabloEmidio Awaiting requested review from PabloEmidio

Assignees
No one assigned
Labels
area/docs Documentation issues/improvements impact/backport Requires backport to stable branch impact/docs Contains or requires documentation changes
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@spirit-q2 @neersighted @PabloEmidio