-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: append subdirectory to archive path (#7575) #7580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In addition, I think we can remove
poetry/src/poetry/installation/executor.py
Lines 589 to 596 in 3e32a4f
assert package.source_url is not None | |
if package.root_dir: | |
req = package.root_dir / package.source_url | |
else: | |
req = Path(package.source_url).resolve(strict=False) | |
if package.source_subdirectory: | |
req /= package.source_subdirectory |
because this part was supposed to consider the subdirectory but apparently it does nothing.
Actually, if we remove this code, we don't need |
Yep those lines do nothing... have removed |
(cherry picked from commit f27308f)
(cherry picked from commit f27308f)
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Resolves: #7575
From @nikowatari's suggestion (#755 (comment)) with added test.