Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system keyring for passwords when available #774

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

abn
Copy link
Member

@abn abn commented Jan 4, 2019

This change introduces the use of system keyring to store repository
passwords when one is available. Passwords are added to and removed from
the keyring using the config command.

Resolves: #210

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code.

Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop branch. If it's a bug fix or only a documentation update, it should be based on the master branch.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

@abn abn force-pushed the issue/210 branch 2 times, most recently from e82c2ba to 32a739c Compare January 4, 2019 00:51
@abn abn force-pushed the issue/210 branch 2 times, most recently from 4c1eb82 to ea633d1 Compare January 15, 2019 17:13
@abn abn force-pushed the issue/210 branch 2 times, most recently from 925ce87 to 68631b3 Compare April 24, 2019 14:06
@abn
Copy link
Member Author

abn commented Apr 25, 2019

Travis builds are failing due to #1049

@abn abn force-pushed the issue/210 branch 2 times, most recently from 1a42cf9 to 099918c Compare April 27, 2019 14:51
@abn
Copy link
Member Author

abn commented Apr 27, 2019

@sdispater any chance we can get recent master changes merged into develop?

The current pre-release 1.0.0a2 being installed for travis builds does not include the recent fixes from 0.12.14. This is causing build failures.

This change introduces the use of system keyring to store repository
passwords when one is available. Passwords are added to and removed from
the keyring using the config command.

Resolves: python-poetry#210
@kasteph kasteph merged commit 964d004 into python-poetry:develop Jun 24, 2019
@toppk toppk mentioned this pull request Aug 23, 2019
2 tasks
@lpfann lpfann mentioned this pull request Aug 27, 2019
3 tasks
@abn abn deleted the issue/210 branch October 6, 2020 21:52
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants