-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix check for in-project-venv #7977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a test feasible?
unclear how to test.
|
f5524e7
to
c26cb92
Compare
(cherry picked from commit 846aee3)
(cherry picked from commit 846aee3)
maybe a way to test this would be to have an end to end test? create a new poetry environment with the flag set to true? |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
looks like #7792 was a bit careless, confusing two things
this undoes those mistakes
fixes #7957