Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a documentation for adding other online source for a dependency. #8246

Closed
wants to merge 2 commits into from

Conversation

hyliu1989
Copy link
Contributor

Pull Request Check List

Resolves: #issue-number-here

  • Added tests for changed code.
  • Updated documentation for changed code.

This PR updates the documentation for command add --source for adding a dependency package with other online source (i.e., other than PyPi but not a git source). It includes a summary sentence and a two-line example that contains source add and add commands.

@hyliu1989 hyliu1989 changed the title Add an documentation for adding other online source for a dependency. Add a documentation for adding other online source for a dependency. Jul 27, 2023
@radoering radoering added the impact/docs Contains or requires documentation changes label Aug 25, 2023
@github-actions
Copy link

Deploy preview for website ready!

✅ Preview
https://website-cpjx4haez-python-poetry.vercel.app

Built with commit 948f3a9.
This pull request is being automatically deployed with vercel-action

Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer to just add a short sentence with a link to https://python-poetry.org/docs/repositories/#installing-from-private-package-sources instead of having almost the same in two places.

@rbavery rbavery mentioned this pull request Feb 24, 2024
2 tasks
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/docs Contains or requires documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry add with --index-url option
3 participants