Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use requests^2.26 #8336

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Use requests^2.26 #8336

merged 2 commits into from
Aug 21, 2023
+2 −2

Conversation

ysk24ok
Copy link
Contributor

@ysk24ok ysk24ok commented Aug 21, 2023 •
edited by radoering
Loading

src/poetry/utils/helpers.py imports atomic_open from requests.utils but the function exists only with requests 2.26.0 or newer.

⭕ https://github.com/psf/requests/blob/v2.26.0/requests/utils.py
❌ https://github.com/psf/requests/blob/v2.25.1/requests/utils.py

Pull Request Check List

Resolves: #8338

  • Added tests for changed code.
  • Updated documentation for changed code.

@ysk24ok
Copy link
Contributor Author

ysk24ok commented Aug 21, 2023

Would it be possible to release the next patch version (1.16.1) after this PR is merged as this is blocking us?

@gsingh1
Copy link

gsingh1 commented Aug 21, 2023

All our builds our failing since the new release too - I'll take this opportunity to start pinning poetry installs to versions 🙃

@gsingh1
Copy link

gsingh1 commented Aug 21, 2023

Opened an issue for this here - #8338

@Fokko Fokko mentioned this pull request Aug 21, 2023
Merged
@dimbleby
Copy link
Contributor

this is blocking us

fix looks fine, but I'm curious as to how this is blocking. poetry is certainly forgetting to force you to update requests - but it isn't blocking you from doing so

@klen
Copy link

klen commented Aug 21, 2023 •
edited
Loading

As an example: I use pip install poetry and actions/setup-python with poetry cache in my github actions. And from poetry 1.6 it breaks for the step actions/setup-python when the action trying to do poetry config --list

@dimbleby
Copy link
Contributor

ah, presumably you're picking up an older requests from your system packages

Couple of points then

  • all documented methods for installing poetry result in it being in its own virtual environment: just pip install poetry is not one of those methods. So you shouldn't be stuck with the system requests at all
  • either way, nothing is stopping you from upgrading requests anyway

again this fix looks fine and I assume it'll be merged in due course; but no-one need be "blocked" by it.

(as others have noted, pinning dependencies in your CI pipelines was obviously a good idea anyway)

@radoering radoering added impact/backport Requires backport to stable branch backport/1.6 labels Aug 21, 2023
@radoering radoering merged commit e2c1731 into python-poetry:master Aug 21, 2023
18 checks passed
@poetry-bot poetry-bot bot mentioned this pull request Aug 21, 2023
Merged
poetry-bot bot pushed a commit that referenced this pull request Aug 21, 2023
@ysk24ok @github-actions
Use requests^2.26 (#8336)
e5baf06 
(cherry picked from commit e2c1731)
radoering pushed a commit that referenced this pull request Aug 21, 2023
@ysk24ok @radoering
Use requests^2.26 (#8336)
a29a53c 
(cherry picked from commit e2c1731)
@radoering radoering mentioned this pull request Aug 21, 2023
Merged
@ysk24ok ysk24ok deleted the ysk24ok-patch-1 branch August 21, 2023 21:57
@samypr100
Copy link
Contributor

samypr100 commented Aug 21, 2023 •
edited
Loading

@gsingh1 All our builds our failing since the new release too - I'll take this opportunity to start pinning poetry installs to versions 🙃

Likely related to #7990, or at least it would help here

@allanlewis
Copy link
Contributor

For future reference, requests.utils.atomic_open was added in #psf/requests#5707 via psf/requests@2463074.

mwalbeck pushed a commit to mwalbeck/docker-python-poetry that referenced this pull request Aug 27, 2023
@mwalbeck
Update dependency poetry to v1.6.1 (#846)
e9d0ca5 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [poetry](https://python-poetry.org/) ([source](https://github.com/python-poetry/poetry), [changelog](https://python-poetry.org/history/)) | minor | `1.5.1` -> `1.6.1` |

---

### Release Notes

<details>
<summary>python-poetry/poetry (poetry)</summary>

### [`v1.6.1`](https://github.com/python-poetry/poetry/blob/HEAD/CHANGELOG.md#161---2023-08-21)

[Compare Source](python-poetry/poetry@1.6.0...1.6.1)

##### Fixed

-   Update the minimum required version of `requests` ([#&#8203;8336](python-poetry/poetry#8336)).

### [`v1.6.0`](https://github.com/python-poetry/poetry/blob/HEAD/CHANGELOG.md#160---2023-08-20)

[Compare Source](python-poetry/poetry@1.5.1...1.6.0)

##### Added

-   **Add support for repositories that do not provide a supported hash algorithm** ([#&#8203;8118](python-poetry/poetry#8118)).
-   **Add full support for duplicate dependencies with overlapping markers** ([#&#8203;7257](python-poetry/poetry#7257)).
-   **Improve performance of `poetry lock` for certain edge cases** ([#&#8203;8256](python-poetry/poetry#8256)).
-   Improve performance of `poetry install` ([#&#8203;8031](python-poetry/poetry#8031)).
-   `poetry check` validates that specified `readme` files do exist ([#&#8203;7444](python-poetry/poetry#7444)).
-   Add a downgrading note when updating to an older version ([#&#8203;8176](python-poetry/poetry#8176)).
-   Add support for `vox` in the `xonsh` shell ([#&#8203;8203](python-poetry/poetry#8203)).
-   Add support for `pre-commit` hooks for projects where the pyproject.toml file is located in a subfolder ([#&#8203;8204](python-poetry/poetry#8204)).
-   Add support for the `git+http://` scheme ([#&#8203;6619](python-poetry/poetry#6619)).

##### Changed

-   **Drop support for Python 3.7** ([#&#8203;7674](python-poetry/poetry#7674)).
-   Move `poetry lock --check` to `poetry check --lock` and deprecate the former ([#&#8203;8015](python-poetry/poetry#8015)).
-   Change future warning that PyPI will only be disabled automatically if there are no primary sources ([#&#8203;8151](python-poetry/poetry#8151)).

##### Fixed

-   Fix an issue where `build-system.requires` were not respected for projects with build scripts ([#&#8203;7975](python-poetry/poetry#7975)).
-   Fix an issue where the encoding was not handled correctly when calling a subprocess ([#&#8203;8060](python-poetry/poetry#8060)).
-   Fix an issue where `poetry show --top-level` did not show top level dependencies with extras ([#&#8203;8076](python-poetry/poetry#8076)).
-   Fix an issue where `poetry init` handled projects with `src` layout incorrectly ([#&#8203;8218](python-poetry/poetry#8218)).
-   Fix an issue where Poetry wrote `.pth` files with the wrong encoding ([#&#8203;8041](python-poetry/poetry#8041)).
-   Fix an issue where `poetry install` did not respect the source if the same version of a package has been locked from different sources ([#&#8203;8304](python-poetry/poetry#8304)).

##### Docs

-   Document **official Poetry badge** ([#&#8203;8066](python-poetry/poetry#8066)).
-   Update configuration folder path for macOS ([#&#8203;8062](python-poetry/poetry#8062)).
-   Add a warning about pip ignoring lock files ([#&#8203;8117](python-poetry/poetry#8117)).
-   Clarify the use of the `virtualenvs.in-project` setting. ([#&#8203;8126](python-poetry/poetry#8126)).
-   Change `pre-commit` YAML style to be consistent with pre-commit's own examples ([#&#8203;8146](python-poetry/poetry#8146)).
-   Fix command for listing installed plugins ([#&#8203;8200](python-poetry/poetry#8200)).
-   Mention the `nox-poetry` package ([#&#8203;8173](python-poetry/poetry#8173)).
-   Add an example with a PyPI source in the pyproject.toml file ([#&#8203;8171](python-poetry/poetry#8171)).
-   Use `reference` instead of deprecated `callable` in the scripts example ([#&#8203;8211](python-poetry/poetry#8211)).

##### poetry-core ([`1.7.0`](https://github.com/python-poetry/poetry-core/releases/tag/1.7.0))

-   Improve performance of marker handling ([#&#8203;609](python-poetry/poetry-core#609)).
-   Allow `|` as a value separator in markers with the operators `in` and `not in` ([#&#8203;608](python-poetry/poetry-core#608)).
-   Put pretty name (instead of normalized name) in metadata ([#&#8203;620](python-poetry/poetry-core#620)).
-   Update list of supported licenses ([#&#8203;623](python-poetry/poetry-core#623)).
-   Fix an issue where PEP 508 dependency specifications with names starting with a digit could not be parsed ([#&#8203;607](python-poetry/poetry-core#607)).
-   Fix an issue where Poetry considered an unrelated `.gitignore` file resulting in an empty wheel ([#&#8203;611](python-poetry/poetry-core#611)).

##### poetry-plugin-export ([`^1.5.0`](https://github.com/python-poetry/poetry-plugin-export/releases/tag/1.5.0))

-   Fix an issue where markers for dependencies required by an extra were not generated correctly ([#&#8203;209](python-poetry/poetry-plugin-export#209)).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40Mi40IiwidXBkYXRlZEluVmVyIjoiMzYuNTIuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Reviewed-on: https://git.walbeck.it/walbeck-it/docker-python-poetry/pulls/846
Co-authored-by: renovate-bot <bot@walbeck.it>
Co-committed-by: renovate-bot <bot@walbeck.it>
@novski novski mentioned this pull request Oct 23, 2023
Open
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radoering radoering radoering approved these changes

Assignees
No one assigned
Labels
impact/backport Requires backport to stable branch
Projects
None yet
Milestone
No milestone
7 participants
@ysk24ok @gsingh1 @dimbleby @klen @samypr100 @allanlewis @radoering