Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider system packages as installed if the venv includes them #8359

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Consider system packages as installed if the venv includes them #8359

merged 6 commits into from
Aug 28, 2023

Commits on Aug 24, 2023

  1. Consider system packages as installed if the venv includes them 

    This changesets adds a getter to `env.virtual_env.VirtualEnv` to check
whether it has access to system packages, and overrides the
`is_path_relative_to_lib` method to take it into account.

This will prevent Poetry from reinstalling system packages in the venv
when they are already installed with a compatible version.

Fixes: python-poetry#6035

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
    @abompard
    abompard committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    610abf7 View commit details
    Browse the repository at this point in the history

  2. The system env can have packages in more than purelib and platlib 

    Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
    @abompard
    abompard committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    113120b View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
    @abompard @radoering
    abompard and radoering committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    40bd409 View commit details
    Browse the repository at this point in the history

  2. Cache the includes_system_site_packages property 

    Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
    @abompard
    abompard committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    3c1b911 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. Add test for original issue

    @radoering
    radoering committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    2268cbd View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Make the detection of system-site-packages more robust 

    References:
- https://github.com/python/cpython/blob/042aa88bcc6541cb8b312f1119452f7a58a5b4df/Lib/site.py#L515-L522
- https://peps.python.org/pep-0405/#specification

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
    @abompard
    abompard committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    3fe197b View commit details
    Browse the repository at this point in the history