Limit default max-workers to 8 #8389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Closing this until confirmed this mitigates the issue. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #3219
When
os.cpu_count()reports a large number of cores, "Connection reset by peer" errors seem to be raised fairly often because of the resulting huge number of requests being made. It struck me as more intuitive for the end user to use a safer value as the default maximum, rather than letting it be unbound to whatever the executing machine reports.With this change, a power user can still configure a larger number of max workers if it is desirable and choose the upper limit themselves.
I do not have any specific data on the number of workers to cause this error to start cropping up due to its non-deterministic nature, so 8 was chosen conservatively. 5 might be best to make the default behavior be only a single core.