Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: report more details on build failures #8479

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

radoering
Copy link
Member

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Yesterday, I was able to reproduce errors similar to #7611 in python-poetry/poetry-plugin-export#235 for a short time. (After a few runs it suddenly stopped to reproduce.)

Nevertheless, I think I gained a few new insights: The build backend is not available in the isolated venv because the installation of the build system requirements failed! Up to now, we did not check the result of the installation. (I do not know yet why the installation fails because the issue stopped to reproduce after I added additional output.)

In order to provide better error messages and facilitate future investigations, this PR checks the return code of the installation of build system requirements and prints additional information in case of failure.

@radoering radoering mentioned this pull request Sep 28, 2023
@Secrus Secrus enabled auto-merge (squash) September 29, 2023 09:04
@Secrus Secrus merged commit 0811469 into python-poetry:master Sep 29, 2023
20 checks passed
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants