-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't fail on skipped file/dir dependencies #8549
Conversation
was the full suggestion! |
I'd update this branch but I have no access currently^^ As there are no poetry tests we implemented, I guess this can be approved, but documentation could be added that dependencies can be skipped. |
I don't follow what you're saying: but there are testcases that could and should be written to go with this code change.
|
Given that tests/integration/test_setup.py could be augmented as well then, given we have no way to know if setup works on individual systems like Ubuntu, Debian, Windows 10, Windows 11, MacOS, etc. |
I still can't follow your point: but poetry's CI pipelines run across a fairly wide range of platforms. Are you trying to make a case that there is something special about this code that should make it either untestable, or not worth testing? Or that it needs extra testing? What is it that you think is special about this code? |
I'm not familiar with this codebase so writing tests is a challenge (with and without AI assistance). Standby while I try to figure this out. |
I think your current draft is not the right direction. I'd try to copy the bit that's maybe confusing about that test - at least in my opinion - is that it non-obviously refers to example projects eg hopefully not too hard to set up another fixture project that looks like the #8548 example, and write a test showing that it can be installed when an irrelevant extra is missing, but not when a relevant extra is missing |
TODO:
|
There we go. Thanks for the guidance @dimbleby! :) |
Good to go now? :) |
looks good to me, but you need someone with the power to press the merge button |
Please update the branch first, looks good. |
Oh I thought that was you, forgive me for the misunderstanding :') |
Awesome! Can I ask when we may expect a release containing this fix? |
No plans so far. I wouldn't expect one this year. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #8548
As suggested by @dimbleby: #8548 (comment)