Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize gitconfig's author field to UTF-8 NFC #8798

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

jmg-duarte
Copy link
Contributor

@jmg-duarte jmg-duarte commented Dec 15, 2023

Pull Request Check List

Resolves: #8779

  • Added tests for changed code.
  • Updated documentation for changed code.

Not sure if the checklist is applicable to this one, let me know!

@radoering
Copy link
Member

Can you add a test, please?
(In poetry-core, there is already a test for combine_unicode so I suppose it should be possible to add a test for init, here.)

@jmg-duarte
Copy link
Contributor Author

Can you add a test, please?

Added. Had to make _validate_author static, but it's inline with other validations.

I'm currently just testing for the offending character though, let me know if you know of more troublemakers I should add!

src/poetry/console/commands/init.py Outdated Show resolved Hide resolved
tests/console/commands/test_init.py Outdated Show resolved Hide resolved
@radoering radoering merged commit 951ba48 into python-poetry:master Dec 18, 2023
20 checks passed
MrGreenTea pushed a commit to MrGreenTea/poetry that referenced this pull request Dec 18, 2023
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry init does not allow é in the authors field
2 participants