Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default python requirement to >= #9558

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Jul 16, 2024

I'm mostly of the view that there is absolutely no sign of python 4.0 happening in the foreseeable future, so it should make no difference to anyone whether they have this upper bound on their python requirement or not.

However, it continues to be a source of noise that this is a thing: and it is true that - in combination with its own solver - poetry's upper bounds becomes self-propagating. Which, if nothing else, becomes an opinionated stance - on a matter which I think hardly deserves an opinion.

I expect that the transition may lead to a small bump in that noise, as resolution on new projects will now be more likely to hit conflicts when pulling in dependencies that have the cap.

Still, on the whole I think that no cap here is a better default and the world will be ever so slightly a better place if poetry makes the change.

(Upper bounds on regular dependencies are a whole different kettle of fish, out of scope here).

@Secrus
Copy link
Member

Secrus commented Jul 17, 2024

I like this (I would be all for removing the ^ marker completely at some point). Poetry 2.0 is a good place to make such a change.

@radoering
Copy link
Member

I did this change in #9135 anyway so I am fine with it. (It cannot hurt to keep it separate in this PR so we do not forget to mention it in the changelog.)

I would be all for removing the ^ marker completely at some point). Poetry 2.0 is a good place to make such a change.

I am neutral to the first part but strongly disagree with the second sentence. Removing it will break poetry-core quite hard. (Harder than I like for 2.0) IMO, that is something that should be deprecated first for quite a while before finally removing it.

@Secrus
Copy link
Member

Secrus commented Jul 18, 2024

@radoering you misunderstood me. The Poetry 2.0 comment was only about the change in this PR.

@dimbleby
Copy link
Contributor Author

imo there's no need for this change to wait for a 2.0, though if the next release is going to be 2.0 anyway then it hardly matters

if you both like it, press the merge button!

@Secrus Secrus merged commit a74d3a7 into python-poetry:main Jul 18, 2024
75 checks passed
@dimbleby dimbleby deleted the default-python-requirement branch July 18, 2024 13:08
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants