-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop support for Python 3.8 #9692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70d335b
to
85ceabc
Compare
From if self._shutdown:
# Cancelling further tasks from being executed
[task.cancel() for task in tasks]
self._executor.shutdown(wait=True) => if self._shutdown:
self._executor.shutdown(wait=True, cancel_futures=True) |
b8189a1
to
0963d48
Compare
9807b17
to
2d5bd65
Compare
ca34402
to
3a1627c
Compare
3a1627c
to
f008575
Compare
Co-authored-by: Sven van Ashbrook <thesven73@googlemail.com>
radoering
approved these changes
Oct 20, 2024
Secrus
pushed a commit
to Secrus/poetry
that referenced
this pull request
Oct 27, 2024
Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com> Co-authored-by: Sven van Ashbrook <thesven73@googlemail.com>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 will be EOL on October. Let's drop the support than for running Poetry itself with it.