Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated cli options and methods, revoke deprecation of --dev #9732

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

radoering
Copy link
Member

There are at least some users who will miss --dev/-D, see https://github.com/orgs/python-poetry/discussions/7530.

Personally, I still tend to remove it.

@Secrus
Copy link
Member

Secrus commented Oct 6, 2024

I would leave the --dev/-D option for add (maybe remove) as an alias for --group dev. It's convenient and since we still support dev-dependencies, it will be confusing to a lot of people when the option disappears.

@radoering
Copy link
Member Author

Then, should we undeprecate it?

@Secrus
Copy link
Member

Secrus commented Oct 6, 2024

Then, should we undeprecate it?

I would say yes, for the commands I mentioned.

@radoering radoering changed the title remove deprecated cli options and methods remove deprecated cli options and methods, revoke deprecation of --dev Oct 11, 2024
@radoering radoering marked this pull request as ready for review October 11, 2024 14:51
@radoering
Copy link
Member Author

I revoked the deprecation in a second commit. (Just for review, can be squashed.)

@radoering radoering enabled auto-merge (squash) October 12, 2024 20:41
@radoering radoering merged commit 8622273 into python-poetry:main Oct 12, 2024
88 checks passed
Secrus pushed a commit to Secrus/poetry that referenced this pull request Oct 27, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants