Fix regression when using empty username/password #9850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might need to disallow empty usernames. |
|
Keeping the commits separate. |
abn
added
impact/docs
|
Deploy preview for website ready! ✅ Preview Built with commit b544ed5. |
abn
force-pushed
the
util-password-manager-empty-creds
branch
from
69f0e91 to
766aca7
Compare
dimbleby
reviewed
Nov 17, 2024
radoering
reviewed
Nov 17, 2024
abn
force-pushed
the
util-password-manager-empty-creds
branch
2 times, most recently
from
940f340 to
29b4102
Compare
dimbleby
reviewed
Nov 17, 2024
abn
force-pushed
the
util-password-manager-empty-creds
branch
from
29b4102 to
640ca13
Compare
dimbleby
reviewed
Nov 17, 2024
abn
force-pushed
the
util-password-manager-empty-creds
branch
from
640ca13 to
18fe382
Compare
This change fixes a regression in the password manager that disallowed the use of empty username or password as required by some self-hosted repositories. Relates-to: python-poetry#9079 python-poetry#2538
abn
force-pushed
the
util-password-manager-empty-creds
branch
from
18fe382 to
b544ed5
Compare
dimbleby
approved these changes
Nov 17, 2024
Secrus
approved these changes
Nov 17, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a regression in the password manager that disallowed the use of empty username or password as required by some self-hosted repositories.
Relates-to: #9079 #2538
Resolves: #4181