Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2022-08-31-announcing-poetry-1-2-0.md #79

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

sryabkov
Copy link
Contributor

@sryabkov sryabkov commented Sep 2, 2022

what

Update 2022-08-31-announcing-poetry-1-2-0.md

why

Add gotchas that we ran into during the upgrade to poetry 1.2.0 to hopefully make the upgrade process smoothers for others. Also, following @neersighted suggestion

notes

This is my first attempt to contribute to this repo, so please pardon any mistakes

@neersighted
Copy link
Member

Thanks for making this PR @sryabkov -- a couple thoughts (though I don't have time for full editorial work yet):

  • I would not describe the 1.2 and 1.1 lockfiles as incompatible -- instead I would state that since 1.1 removes unnecessary dependencies by default, and because Poetry 1.2 no longer special-cases setuptools, if you have an indirect dependency on setuptools and install a 1.2 lockfile with 1.1, 1.1 may remove setuptools unexpectedly. The issue is very specific, and a high-level summary of the specifics is better than a vague warning most users will not encounter.
  • Keyring is new and we're going to have to work out the kinks, which are mostly local configuration/OS-level issues. Instead of a vague and scary statement, something more along the lines of "depending on your local configuration, Keyring may not be able to communicate with a backend or determine that there is no working backend. Error handling will improve, but the meantime setting the backend to Fail (env var here, link to issue for more details) will allow you to rule out the keyring component when setting up authentication."
  • The final bullet point is extremely vague. I would probably simplify it to state that due to pip bugs, especially with older pip versions, the parallel installer may experience race conditions. These should mostly be solved in newer pip versions, but can be identified or worked around by setting installer.max-workers=1. This is not directly related to turning the new installer off, but a reference to the fact that some people previously turned it off, and the better way to solving it being turning off parallelism may help.

@sryabkov
Copy link
Contributor Author

sryabkov commented Sep 4, 2022

@neersighted Thank you for your feedback. I updated the PR based on your comments.

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Deploy preview for website ready!

✅ Preview
https://website-pch97kqjs-python-poetry.vercel.app

Built with commit 587fcac.
This pull request is being automatically deployed with vercel-action

@sryabkov
Copy link
Contributor Author

sryabkov commented Sep 6, 2022

@neersighted I looked at the website preview, and added the missing backquote. If you are OK with the verbiage, this should be good to go.

@sryabkov
Copy link
Contributor Author

sryabkov commented Sep 8, 2022

@neersighted Sorry to bug you, I see from various threads in the poetry repo that you are really busy tending to requests and issues, but it looks like somebody found and linked this PR, so maybe it would be good to update the 1.2 release blog post on the website so that more people would be aware of possible issues?

This is, of course, unless you have some other issues with this PR.

…uncement

Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants