Skip to content

Build 5.15.0 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 21, 2020
Merged

Build 5.15.0 #63

merged 3 commits into from
Sep 21, 2020

Conversation

altendky
Copy link
Collaborator

@altendky altendky commented Sep 14, 2020 •
edited
Loading

Draft for:

  • Rebuilding SIP stubs
  • Unbreak CI back to its regular brokenness
    • Nevermind, in this case upstream 5.15.0 really just is that broken.

@altendky
Copy link
Collaborator Author

Am I supposed to rebuild the PyQt5-Stubs/sip.pyi somehow?

@altendky altendky mentioned this pull request Sep 14, 2020
Merged
2 tasks
@BryceBeagle
Copy link
Collaborator

I think building the sip stubs needs to be added to the Dockerfile still

@altendky altendky marked this pull request as draft September 14, 2020 12:47
@altendky altendky mentioned this pull request Sep 14, 2020
Closed
@altendky
Copy link
Collaborator Author

@BryceBeagle is it documented how to build them, or does that need figured out as well? I'm just starting to look around a bit.

@altendky altendky changed the title 5.15.0 Build 5.15.0 Sep 14, 2020
@altendky
Copy link
Collaborator Author

@stlehmann, it looks like you have committed all the updates to sip.pyi. I would have thought it would have come from PyQt5-sip but I haven't figured out any way to get it from there. Perhaps I'm looking in the wrong place? Once I figure out how to get or make it I'll certainly add it to the Dockerfile.

@altendky
Copy link
Collaborator Author

Nevermind, looks like it's in SIP proper and included in any install.

@altendky altendky marked this pull request as ready for review September 18, 2020 18:53
@altendky
Copy link
Collaborator Author

Do you all get emails when I remove the draft mark? I'm not sure if I need to ping with a comment like this as well to generate a notification.

@altendky altendky marked this pull request as draft September 19, 2020 00:58
@altendky altendky marked this pull request as ready for review September 19, 2020 01:30
@BryceBeagle
Copy link
Collaborator

BryceBeagle commented Sep 21, 2020 •
edited
Loading

I turned off all email notifications, but I don't know if I got an in-Github notification for that specific event either. The notification log just shows that something happnened in a PR, but not what.

@altendky altendky merged commit e1cdd42 into python-qt-tools:upstream Sep 21, 2020
@altendky altendky deleted the build_5.15.0 branch September 21, 2020 23:04
bluebird75 pushed a commit to bluebird75/PyQt5-stubs that referenced this pull request Aug 24, 2021
@altendky
Merge pull request python-qt-tools#63 from altendky/build_5.15.0
dd9fbef 
Build 5.15.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryceBeagle BryceBeagle BryceBeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altendky @BryceBeagle